Skip to content

ci: Run tests with both no features and all features #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Conversation

sbernauer
Copy link
Member

Description

Came up in #1026 (review).
Although, for some reason it wouldn't have catched it

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

@sbernauer sbernauer requested a review from NickLarsenNZ May 8, 2025 06:38
@sbernauer sbernauer self-assigned this May 8, 2025
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering May 8, 2025
@Techassi Techassi changed the title chore(ci): Run all tests with none and all features ci Run tests with borh no features and all features May 8, 2025
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 8, 2025
@Techassi Techassi changed the title ci Run tests with borh no features and all features ci: Run tests with borh no features and all features May 8, 2025
@Techassi Techassi changed the title ci: Run tests with borh no features and all features ci: Run tests with both no features and all features May 8, 2025
@sbernauer sbernauer added this pull request to the merge queue May 8, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 8, 2025
Merged via the queue into main with commit 51dc280 May 8, 2025
8 checks passed
@sbernauer sbernauer deleted the chore/ci-tests branch May 8, 2025 07:11
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants