Skip to content

chore: remove -nodeport discovery configmap #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2025
Merged

chore: remove -nodeport discovery configmap #868

merged 3 commits into from
Jun 10, 2025

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Jun 10, 2025 •
edited
Loading

Description

Implementation for #765. Removes the deprecated -nodeport discovery ConfigMap (#813). Removes the Note about the -nodeport discovery CM from the Discovery page of Kafka Operator.

Integrationtests

--- PASS: kuttl (828.67s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/configuration_kafka-latest-3.7.2_zookeeper-latest-3.9.3_openshift-false (31.21s)
        --- PASS: kuttl/harness/smoke_kafka-3.9.0_zookeeper-3.9.3_use-client-tls-false_openshift-false (98.06s)
        --- PASS: kuttl/harness/cluster-operation_kafka-latest-3.7.2_zookeeper-latest-3.9.3_openshift-false (80.41s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.9.3_upgrade_old-3.7.2_upgrade_new-3.9.0_use-client-tls-true_use-client-auth-tls-true_openshift-false (80.75s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.9.3_upgrade_old-3.7.2_upgrade_new-3.9.0_use-client-tls-true_use-client-auth-tls-false_openshift-false (77.88s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.9.3_upgrade_old-3.7.2_upgrade_new-3.9.0_use-client-tls-false_use-client-auth-tls-true_openshift-false (76.35s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.9.3_upgrade_old-3.7.2_upgrade_new-3.9.0_use-client-tls-false_use-client-auth-tls-false_openshift-false (71.85s)
        --- PASS: kuttl/harness/tls_kafka-3.9.0_zookeeper-latest-3.9.3_use-client-tls-true_use-client-auth-tls-false_openshift-false (127.90s)
        --- PASS: kuttl/harness/tls_kafka-3.9.0_zookeeper-latest-3.9.3_use-client-tls-true_use-client-auth-tls-true_openshift-false (134.67s)
        --- PASS: kuttl/harness/tls_kafka-3.9.0_zookeeper-latest-3.9.3_use-client-tls-false_use-client-auth-tls-false_openshift-false (53.97s)
        --- PASS: kuttl/harness/tls_kafka-3.9.0_zookeeper-latest-3.9.3_use-client-tls-false_use-client-auth-tls-true_openshift-false (129.18s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-stable (77.78s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-unstable (77.15s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-stable (87.21s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-cluster-internal (75.09s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-unstable (95.02s)
        --- PASS: kuttl/harness/logging_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false (67.65s)
        --- PASS: kuttl/harness/delete-rolegroup_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false (49.97s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-false_krb5-1.21.1_kerberos-realm-CLUSTER.LOCAL_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-cluster-internal (74.14s)
        --- PASS: kuttl/harness/smoke_kafka-3.9.0_zookeeper-3.9.3_use-client-tls-true_openshift-false (45.35s)
PASS

Openshift

--- PASS: kuttl (382.91s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/delete-rolegroup_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-true (75.04s)
        --- PASS: kuttl/harness/configuration_kafka-latest-3.7.2_zookeeper-latest-3.9.3_openshift-true (34.90s)
        --- PASS: kuttl/harness/smoke_kafka-3.9.0_zookeeper-3.9.3_use-client-tls-true_openshift-true (134.25s)
        --- PASS: kuttl/harness/kerberos_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-true_krb5-1.21.1_kerberos-realm-PROD.MYCORP_kerberos-backend-mit_broker-listener-class-cluster-internal_bootstrap-listener-class-external-unstable (80.71s)
        --- PASS: kuttl/harness/cluster-operation_kafka-latest-3.7.2_zookeeper-latest-3.9.3_openshift-true (102.50s)
        --- PASS: kuttl/harness/logging_kafka-3.9.0_zookeeper-latest-3.9.3_openshift-true (78.03s)
        --- PASS: kuttl/harness/tls_kafka-3.9.0_zookeeper-latest-3.9.3_use-client-tls-true_use-client-auth-tls-true_openshift-true (131.33s)
        --- PASS: kuttl/harness/upgrade_zookeeper-3.9.3_upgrade_old-3.7.2_upgrade_new-3.9.0_use-client-tls-true_use-client-auth-tls-true_openshift-true (104.63s)
PASS

Release Note Snippet

The -nodeport discovery ConfigMap has been deprecated in 25.3 and is removed as of this release. Use the primary discovery ConfigMap instead.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Jun 10, 2025
@xeniape xeniape linked an issue Jun 10, 2025 that may be closed by this pull request
Remove -nodeport discovery configmap #765
Closed
@xeniape xeniape marked this pull request as ready for review June 10, 2025 12:29
@xeniape xeniape added release-note Denotes a PR that will be considered when it comes time to generate release notes. release/25.7.0 labels Jun 10, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Jun 10, 2025
NickLarsenNZ
NickLarsenNZ approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for the Release Note snippet.

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 10, 2025
@xeniape xeniape added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit 03f222a Jun 10, 2025
17 checks passed
@xeniape xeniape deleted the chore/remove-nodeport-discovery branch June 10, 2025 15:12
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@xeniape xeniape

Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/25.7.0
Projects
Stackable Engineering
Status: Development: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove -nodeport discovery configmap
2 participants
@xeniape @NickLarsenNZ