Skip to content

docs(code-style-guide): Add section about unwraps #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 2, 2025

Conversation

Techassi
Copy link
Member

This PR adds two sections about unwrap and why it is not recommended to be used.

@Techassi Techassi self-assigned this May 21, 2025
Copy link

netlify bot commented May 21, 2025

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit a2ab5a6
🔍 Latest deploy log https://app.netlify.com/projects/stackable-docs/deploys/683db13ea6731a0008ee0dde
😎 Deploy Preview https://deploy-preview-741--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete review. Happy to help on a screenshare.

@Techassi Techassi requested a review from NickLarsenNZ June 2, 2025 13:49
@Techassi Techassi marked this pull request as ready for review June 2, 2025 13:49
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion, otherwise good.

Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@Techassi Techassi requested a review from NickLarsenNZ June 2, 2025 14:00
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
@Techassi Techassi requested a review from NickLarsenNZ June 2, 2025 14:12
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Techassi Techassi enabled auto-merge June 2, 2025 14:17
@Techassi Techassi added this pull request to the merge queue Jun 2, 2025
Merged via the queue into main with commit 5b53280 Jun 2, 2025
7 checks passed
@Techassi Techassi deleted the docs/add-unwrap-to-code-style-guide branch June 2, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants