Skip to content

Add VMWare Tanzu notes. Also differentiate between supported and tested k8s #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2025
Merged

Add VMWare Tanzu notes. Also differentiate between supported and tested k8s #719

merged 5 commits into from
Mar 20, 2025

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Mar 20, 2025 •
edited
Loading

Outcome of talking to a prospect.
I only want to add Tanzu, don't care to much about the other changes.
Please feel free to edit this branch directly if you have feelings!

@sbernauer sbernauer requested review from lfrancke and nightkr March 20, 2025 12:20
@netlify Netlify
Copy link

netlify bot commented Mar 20, 2025 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit ecbdfd7
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/67dc12f97b0ae10008a3d886
😎 Deploy Preview https://deploy-preview-719--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Mar 20, 2025
@nightkr
Copy link
Member

nightkr commented Mar 20, 2025 •
edited
Loading

I think tested still implies too much.. Ideally we might want to do something similar to Rustc's tier system? But this also seems like a bigger Business Decision™️ tbh.

nightkr
nightkr previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now in the name of harm reduction, though I'd still like to see us revisit this eventually.

@sbernauer @nightkr
Update modules/ROOT/pages/kubernetes/index.adoc
96ebc78 
Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
@sbernauer
Copy link
Member Author

Yeah, I was also thinking what would be a good term. "Tried out on" also sounds a bit strange.
Having a tier system sounds like a good idea, but yeah bigger decision for @lfrancke.
I think the current PR at least improves the current situation and helps VMWare users

@lfrancke
Copy link
Member

I'm with both of you. I'd also reword it a bit. I'll try to come up with a suggestion. Give me a minute.

lfrancke
lfrancke requested changes Mar 20, 2025
View reviewed changes
@lfrancke
Copy link
Member

What I'd also like to add, if you know @nightkr, is a note on which Tanzu version we checked this.
This information could go stale and with us not really testing this on these products it'd be nice if we could at least say something along the lines of "These notes were written for VMWare Tanzu version X.Y and might not apply to other versions."

@lfrancke
Copy link
Member

And while we're at it: We could add PlusServer as well
@labrenbe was there anything we needed to do for PlusServer?

@nightkr
Copy link
Member

nightkr commented Mar 20, 2025

Tanzu version: I don't know, I've asked them at https://stackable-workspace.slack.com/archives/C08HGALNX3M/p1742475543155179?thread_ts=1742307376.640879&cid=C08HGALNX3M. That said, getting into these weeds we'll probably also want to mention that we haven't necessarily tested all of SDP against these targets.

sbernauer and others added 3 commits March 20, 2025 14:02
@sbernauer @lfrancke
Wording
07757b6 
Co-authored-by: Lars Francke <github@lars-francke.de>
@sbernauer
Add plusserver
3ccb05c
@sbernauer @lfrancke
Apply suggestions from code review
ecbdfd7 
Co-authored-by: Lars Francke <github@lars-francke.de>
@sbernauer sbernauer requested a review from lfrancke March 20, 2025 13:07
@labrenbe
Copy link
Member

And while we're at it: We could add PlusServer as well @labrenbe was there anything we needed to do for PlusServer?

No, there were no extra steps needed for running the demo.

@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Mar 20, 2025
@nightkr nightkr mentioned this pull request Mar 20, 2025
Open
@sbernauer
Copy link
Member Author

Many thanks for your comments and @nightkr for starting the follow-up discussion!

@sbernauer sbernauer added this pull request to the merge queue Mar 20, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 20, 2025
Merged via the queue into main with commit 5213383 Mar 20, 2025
7 checks passed
@sbernauer sbernauer deleted the feat/add-vmware-tanzu branch March 20, 2025 13:20
nightkr
nightkr reviewed Mar 20, 2025
View reviewed changes
modules/ROOT/partials/supported-kubernetes-distributions.adoc
* xref:kubernetes/aks.adoc[Azure Kubernetes Service]
* xref:kubernetes/gke.adoc[Google Kubernetes Engine]
* xref:kubernetes/ionos-managed-k8s.adoc[IONOS Managed Kubernetes]
* xref:kubernetes/ionos-managed-stackable.adoc[IONOS Managed Stackable]
* https://kind.sigs.k8s.io/[kind]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of confusing IMO that some of these lead to the official upstream product page, and some lead to our docs on them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to always link to our internal guide, however, for some clouds we don't have any to link to.
I'm also happy to remove upstream links entirely if you prefer that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, will raise a PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at #720

@sbernauer sbernauer self-assigned this Mar 20, 2025
@nightkr
Copy link
Member

nightkr commented Mar 20, 2025

@lfrancke They're using TKGI 1.21 with K8s 1.30.7 (Tanzu Kubernetes Grid Integrated, presumably)

@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr left review comments

@lfrancke lfrancke lfrancke approved these changes

Assignees

@sbernauer sbernauer

Labels
release/25.3.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbernauer @nightkr @lfrancke @labrenbe