Documentation about setup in in air-gapped environment #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lfrancke
reviewed
Jan 18, 2024
modules/tutorials/pages/running_stackable_in_an_airgapped_environment.adoc
Outdated
Show resolved
Hide resolved
|
Thanks! I like it too, I think we can merge it as is. I have an optional suggestion: Add a "Further reading" or "Read more" bit, where you link to offline image veriifcation. I think someone that reads this tutorial would be interested in that topic too, it helps with discoverability in the docs. but LGTM!! |
|
It was already there, but a bit hidden at the end. It's still at the end, but I made it more prominent. |
lfrancke
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270