-
-
Notifications
You must be signed in to change notification settings - Fork 12
Document how to verify image signatures in an air-gapped environment #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I just read through it, the first section reads nicely! I'm just a bit confused about the air-gapped part, maybe we can have a call about it.
One thing in general, adress the reader as "you" and don't use the "we". Also further down, don't say "the customer". The docs are written for the customer, so it's just "you"
modules/tutorials/pages/enabling_verification_of_image_signatures.adoc
Outdated
Show resolved
Hide resolved
modules/tutorials/pages/enabling_verification_of_image_signatures.adoc
Outdated
Show resolved
Hide resolved
modules/tutorials/pages/enabling_verification_of_image_signatures.adoc
Outdated
Show resolved
Hide resolved
modules/tutorials/pages/enabling_verification_of_image_signatures.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for your work on this!
Fixes stackabletech/issues#437
I switched out Kyverno for the Sigstore Policy Controller, since the support for air-gapped environments is more mature than Kyverno's (at the moment at least) and added some guidelines and explanations on how signature verification in an air-gapped environment can be done.
Notes for the reviewer:
The whole topic is not trivial and maybe not easy to reproduce, this documentation might be helpful as well: https://github.com/stackabletech/documentation-airgapped-setup
It's a step-by-step guide on how to setup an air-gapped cluster on IONOS and how to configure the Policy Controller with a TUF mirror.