Skip to content

Add concepts page on Pod disruptions #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 25, 2023
Merged

Add concepts page on Pod disruptions #454

merged 18 commits into from
Sep 25, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 19, 2023 •
edited
Loading

@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit a8c517d
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/6511844c3080ed0008617121
😎 Deploy Preview https://deploy-preview-454--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sbernauer sbernauer mentioned this pull request Sep 19, 2023
Closed
@fhennig
Copy link
Contributor

fhennig commented Sep 20, 2023 •
edited
Loading

an you explicitly define a section "proposed solution"? as a heading in there somewhere

Edit: this was meant to be for the ADR, please disregard here!

@sbernauer sbernauer self-assigned this Sep 21, 2023
@adwk67 adwk67 self-requested a review September 22, 2023 08:58
@sbernauer sbernauer mentioned this pull request Sep 22, 2023
Merged
adwk67
adwk67 requested changes Sep 22, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly minor things.

sbernauer and others added 4 commits September 22, 2023 16:12
@sbernauer sbernauer requested a review from adwk67 September 22, 2023 14:20
adwk67
adwk67 previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM!

@sbernauer sbernauer requested a review from adwk67 September 25, 2023 08:00
adwk67
adwk67 requested changes Sep 25, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this: it's really helpful (for me at least!) to have all of this in one place.

@sbernauer @adwk67
Apply suggestions from code review
a8c517d 
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
@sbernauer sbernauer requested a review from adwk67 September 25, 2023 13:01
@sbernauer sbernauer enabled auto-merge September 25, 2023 13:02
@sbernauer sbernauer added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit b054a70 Sep 25, 2023
@sbernauer sbernauer deleted the concepts-pdb branch September 25, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@sbernauer sbernauer

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @fhennig @adwk67