Skip to content

Updated text for service exposition #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 31, 2023
Merged

Updated text for service exposition #446

merged 9 commits into from
Aug 31, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Aug 31, 2023 •
edited
Loading

Refined the text for service exposition, part of #393

@netlify
Copy link

netlify bot commented Aug 31, 2023 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit f1a9a5c
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/64f08e7240b5340008429227
😎 Deploy Preview https://deploy-preview-446--stackable-docs.netlify.app/home/nightly/concepts/service-exposition
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fhennig fhennig marked this pull request as ready for review August 31, 2023 11:30
@fhennig fhennig mentioned this pull request Aug 31, 2023
Closed
1 task
@razvan razvan assigned razvan and fhennig and unassigned razvan Aug 31, 2023
@razvan razvan self-requested a review August 31, 2023 11:49
razvan
razvan previously approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is good. I only rephrased some ideas because I thought it was easier to read.

fhennig and others added 6 commits August 31, 2023 14:57
@fhennig @razvan
Update modules/concepts/pages/service-exposition.adoc
980e4ed 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig @razvan
Update modules/concepts/pages/service-exposition.adoc
3a13ea6 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig @razvan
Update modules/concepts/pages/service-exposition.adoc
eec5eb0 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig @razvan
Update modules/concepts/pages/service-exposition.adoc
2fd54b0 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig @razvan
Update modules/concepts/pages/service-exposition.adoc
2d78e4d 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig @razvan
Update modules/concepts/pages/service-exposition.adoc
f1a9a5c 
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
@fhennig fhennig requested a review from razvan August 31, 2023 12:58
@fhennig
Copy link
Contributor Author

fhennig commented Aug 31, 2023

All good suggestions, all merged, thank you very much!

@fhennig fhennig added this pull request to the merge queue Aug 31, 2023
Merged via the queue into main with commit ab86517 Aug 31, 2023
@fhennig fhennig deleted the 393-improve-listenerclass-docs branch August 31, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@fhennig fhennig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @razvan