Skip to content

Add some more information and examples to the image selection documentation #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 11, 2023
Merged

Add some more information and examples to the image selection documentation #445

merged 6 commits into from
Sep 11, 2023

Conversation

soenkeliebau
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit d00bf7f
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/64feba2377e5ed0008cfd125
😎 Deploy Preview https://deploy-preview-445--stackable-docs.netlify.app/home/nightly/concepts/product_image_selection
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soenkeliebau soenkeliebau requested a review from a team August 30, 2023 06:58
@fhennig fhennig self-requested a review August 30, 2023 07:03
fhennig
fhennig suggested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you for expanding this section, very nice!

I have a few things, but mainly cosmetic. I also saw in a different part of the document a typo "wth" instead of "with", maybe you could fix that too while you're editing the document?

@soenkeliebau soenkeliebau requested a review from fhennig August 30, 2023 20:34
@soenkeliebau
Copy link
Member Author

Hey, thank you for expanding this section, very nice!

I have a few things, but mainly cosmetic. I also saw in a different part of the document a typo "wth" instead of "with", maybe you could fix that too while you're editing the document?

Thanks for reviewing! I hopefully addressed all comments.

fhennig
fhennig previously approved these changes Aug 31, 2023
View reviewed changes
@fhennig
Copy link
Contributor

fhennig commented Aug 31, 2023

Nice!

sbernauer
sbernauer previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soenkeliebau soenkeliebau dismissed stale reviews from sbernauer and fhennig via d00bf7f September 11, 2023 06:56
sbernauer
sbernauer approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@soenkeliebau soenkeliebau added this pull request to the merge queue Sep 11, 2023
Merged via the queue into main with commit 5248c67 Sep 11, 2023
@soenkeliebau soenkeliebau deleted the feat/adr23 branch September 11, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@fhennig fhennig fhennig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soenkeliebau @fhennig @sbernauer