Don't delete CRDs when upgrading #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://stackable-workspace.slack.com/archives/C031BTE7ZGC/p1683797224359929 This should also be cherry-picked to `main`
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
adwk67
approved these changes
May 15, 2023
|
Should I update the backport PR, or will we handle that as part of the 23.4.1 release process? @adwk67 |
@nightkr Yes please! The 23.4.1 won't make any automatic changes, so everything should be cherry-picked into branch 23.4 first, before we tag and build everything. |
|
Ok. |
nightkr
added a commit
that referenced
this pull request
May 15, 2023
nightkr
added a commit
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://stackable-workspace.slack.com/archives/C031BTE7ZGC/p1683797224359929
This replaces #402 (because I was dumb and should have done the PR against
mainfirst), and should be cherry-picked back into 23.4.