Skip to content

Add concepts page on service exposition #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 25, 2023

Conversation

sbernauer
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 5871a20
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/64478749cac5f200086325f1
😎 Deploy Preview https://deploy-preview-398--stackable-docs.netlify.app/home/nightly/concepts/service-exposition
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sbernauer sbernauer force-pushed the concepts-page-service-exposition branch from 49cc2d4 to a567b0c Compare April 25, 2023 07:26
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes (no need to apply all).

sbernauer and others added 7 commits April 25, 2023 09:47
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer
Copy link
Member Author

Thx for the quick review!

@sbernauer
Copy link
Member Author

bors r+

@bors
Copy link

bors bot commented Apr 25, 2023

Configuration problem:
bors.toml: not found

@sbernauer sbernauer requested a review from maltesander April 25, 2023 07:56
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer merged commit abf1744 into main Apr 25, 2023
@sbernauer sbernauer deleted the concepts-page-service-exposition branch April 25, 2023 08:13
sbernauer added a commit that referenced this pull request Apr 25, 2023
* Add concepts page on service exposition

* Rename file

* Update modules/concepts/pages/service-exposition.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

* Update modules/concepts/pages/service-exposition.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

* Update modules/concepts/pages/service-exposition.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

* Update modules/concepts/pages/service-exposition.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

* Update modules/concepts/pages/service-exposition.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

* Update modules/concepts/pages/service-exposition.adoc

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

* Apply suggestion

---------

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@razvan razvan mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants