Skip to content

Build from CI cloned repo (and fix netlify previews) #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Apr 24, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Apr 24, 2023

This PR changes the production build to build from the locally fetched repo in the CI.

As the build happens in netlify, a script is necessary to fetch all to content - netlify does a bare clone initially.

As a consequence the netlify previews in PRs now actually work!

@netlify
Copy link

netlify bot commented Apr 24, 2023

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit 13927b9
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/6446985a1491700008782291
😎 Deploy Preview https://deploy-preview-392--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fhennig fhennig changed the title dummy change on index Build from CI cloned repo (and fix netlify previews) Apr 24, 2023
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@fhennig
Copy link
Contributor Author

fhennig commented Apr 24, 2023

lovely jubbly!

@fhennig fhennig merged commit db9bfdf into main Apr 24, 2023
@fhennig fhennig deleted the feat/netlify-preview-fix branch April 24, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants