Skip to content

chore: Enlargen max-width to 1920px #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Feb 21, 2025

This popped up in stackabletech/nifi-operator#753 (comment)
Relevant Slack discussion: https://stackable-workspace.slack.com/archives/C02LP2HLM9Q/p1740128583523509

This uncovers a bigger problem: The site currently is not responsive, the left and right side of the screen are just white, thus wasted space:
image

Often times we have content we can not control the size of (e.g. stackablectl stacklet list output, some log messages, snippets of a Python script). It also feels a bit silly that the actual content only takes up +- 50% of the screen (depending on the Window size).

I therefore propose to remove the artificial width limit and let the users decide on the width... well by resizing the window to whatever width they prefer. Zooming in and out suddenly also starts working 🤯

Before on a half(!) of the 21/9 screen
image
After
You can now zoom out if needed!
image

Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the screenshots and I like it.

@nightkr
Copy link
Member

nightkr commented Feb 21, 2025

I don't know; the width of the codeblocks is a real problem, but overly wide prose text can also be a readability problem. It's not so bad on 1080p, but go wider than that and it quickly gets ridiculous. Maybe it makes sense to limit the width of text paragraphs but let code blocks float all the way out to the sides? That could make alignment look funky, though...

I don't think "just adjust the window size, dummy" is a good answer; there are many sites that do benefit from wider display, and I think it's disruptive to ask people to resize their windows every time they change tab.

Zooming in and out suddenly also starts working 🤯

Zoom already works for me, as is..?

@sbernauer
Copy link
Member Author

Zoom already works for me, as is..?

Looking at e.g. https://docs.stackable.tech/home/stable/demos/data-lakehouse-iceberg-trino-spark/#_list_the_deployed_stackable_services sure I can zoom, but the amount of text displayed does not change. So there is no combination of zoom and browser window where I can see the full stackablectl stacklet list output.
With the PR, the zoom level influence the amount of text shown

@sbernauer sbernauer self-assigned this Feb 24, 2025
@sbernauer sbernauer changed the title fix: Don't set max-width on main container chore: Enlargen max-width to 1920px Feb 25, 2025
@sbernauer sbernauer requested a review from razvan February 25, 2025 14:43
@sbernauer
Copy link
Member Author

As discussed in daily, merging this - let's see how it goes

@sbernauer sbernauer merged commit 4ec4bea into stackable Feb 26, 2025
2 checks passed
@sbernauer sbernauer deleted the fix/remove-max-width branch February 26, 2025 08:12
sbernauer added a commit to stackabletech/documentation that referenced this pull request Feb 26, 2025
github-merge-queue bot pushed a commit to stackabletech/documentation that referenced this pull request Feb 26, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Mar 3, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants