Skip to content

Enable navigation on mobile devices #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Conversation

siegfriedweber
Copy link
Member

The menu button opens the navigation menu. The layout is done completely in CSS (and not in JavaScript) so that the layout does not break if changing the viewport (e.g. by rotating the device) while the menu is open.

@siegfriedweber siegfriedweber requested a review from lfrancke March 11, 2022 12:51
@siegfriedweber siegfriedweber self-assigned this Mar 11, 2022
@lfrancke
Copy link
Member

I tried this locally and it doesn't work for me. Let's look together when you're back.

@siegfriedweber
Copy link
Member Author

The documentation-ui works now together with the documentation. A script in the UI bundle was not compatible with the custom landing page.

However, the UI bundle can only be built on my machine if I install postcss beforehand (npm install postcss). It seems to be no issue in the GitHub action, so I did not add it to the package.json.

Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it, works for me now

@siegfriedweber siegfriedweber merged commit 41b7b1e into stackable Mar 21, 2022
@siegfriedweber siegfriedweber deleted the mobile-nav-css-only branch March 21, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants