Skip to content

Fix: sidebar and toolbar CSS #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Fix: sidebar and toolbar CSS #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc634ed
I think I fixed it
Nov 15, 2023
93540f6
documentation, cleanup
Nov 15, 2023
4c580b3
more cleanup
Nov 15, 2023
4ac42eb
more cleanup
Nov 15, 2023
688b42a
more documentation
Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/css/nav.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
/* This file contains the CSS for the sidebar navigation.
* The vertical navigation at the top is in the header.css
* At less than 770px, the navbar disappears and is opened with
* a button in the toolbar.
*
* Some of the responsiveness is about adjusting the height of the
* menu. On smaller screens the vertical menu disappears, so the height
* of the sidebar menu needs to be adjusted.
*/

.nav-container {
position: fixed;
top: var(--navbar-height);
Expand Down Expand Up @@ -32,7 +42,7 @@
background: var(--nav-background);
position: relative;
top: var(--toolbar-height);
height: var(--nav-height);
height: calc(100% - var(--navbar-sub-height));
}

@media screen and (min-width: 769px) {
Expand All @@ -43,10 +53,11 @@

@media screen and (min-width: 1024px) {
.nav {
top: var(--navbar-height);
top: calc(var(--navbar-height) + var(--navbar-sub-height));
box-shadow: none;
position: sticky;
height: var(--nav-height--desktop);
margin-top: var(--navbar-sub-height);
}
}

Expand All @@ -63,7 +74,7 @@ html.is-clipped--nav {
.nav-panel-menu {
overflow-y: scroll;
overscroll-behavior: none;
height: var(--nav-panel-menu-height);
height: 100%;
}

.nav-panel-menu:not(.is-active) .nav-menu {
Expand Down
11 changes: 11 additions & 0 deletions src/css/toolbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/* The toolbar contains a home link and breakcrumbs and is found
* right above the article content.
* On smaller screens it also contains a button to show the sidebar menu.
*/

.toolbar {
color: var(--toolbar-font-color);
align-items: center;
Expand All @@ -12,6 +17,12 @@
z-index: var(--z-index-toolbar);
}

@media screen and (min-width: 1024px) {
.toolbar {
top: calc(var(--navbar-height) + var(--navbar-sub-height));
}
}

.toolbar a {
color: inherit;
}
Expand Down
3 changes: 0 additions & 3 deletions src/css/vars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,13 +123,10 @@
--navbar-height: calc(73 / var(--rem-base) * 1rem);
--navbar-sub-height: calc(45 / var(--rem-base) * 1rem);
--toolbar-height: calc(45 / var(--rem-base) * 1rem);
--drawer-height: var(--toolbar-height);
--body-top: calc(var(--navbar-height) + var(--navbar-sub-height));
--body-min-height: calc(100vh - var(--body-top));
--nav-height: calc(var(--body-min-height) - var(--toolbar-height));
--nav-height--desktop: var(--body-min-height);
--nav-panel-menu-height: calc(100% - var(--drawer-height));
--nav-panel-explore-height: calc(50% + var(--drawer-height));
--nav-width: calc(270 / var(--rem-base) * 1rem);
--toc-top: calc(var(--body-top) + var(--toolbar-height));
--toc-height: calc(100vh - var(--toc-top) - 2.5rem);
Expand Down