Skip to content

Fix 24.7 demos #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2024
Merged

Fix 24.7 demos #67

merged 5 commits into from
Jul 26, 2024

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Jul 25, 2024 •
edited
Loading

  • stack/end-to-end-security: change krb5 version to 1.21.1
  • stack/nifi-kafka-druid-superset-s3: use credentialsSecret: druid-db-credentials in druid cluster yaml
  • adapt to hive breaking credential secret changes

@maltesander maltesander mentioned this pull request Jul 25, 2024
Closed
NickLarsenNZ
NickLarsenNZ approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will there be a similar change for main, eg: docker.stackable.tech/stackable/krb5:1.21.1-stackable0.0.0-dev?

@NickLarsenNZ NickLarsenNZ self-requested a review July 25, 2024 12:42
NickLarsenNZ
NickLarsenNZ requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to go to the release-24.7 branch?

@maltesander
Copy link
Member Author

Is this supposed to go to the release-24.7 branch?

Yeah it should, but wanna collect here first, maybe other demos need fixing as well.

NickLarsenNZ
NickLarsenNZ reviewed Jul 26, 2024
View reviewed changes
@NickLarsenNZ NickLarsenNZ self-requested a review July 26, 2024 13:16
NickLarsenNZ
NickLarsenNZ approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, release images are preferred in main for stability.

@maltesander maltesander added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit b07c62d Jul 26, 2024
1 check passed
@maltesander maltesander deleted the fix/release-24-7-demos branch July 26, 2024 13:21
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Jul 29, 2024 •
edited
Loading

@maltesander is there a PR with the same changes going into the release-24.7 branch?
I had a quick look and didn't see one, but would like to link it here.

@maltesander
Copy link
Member Author

I wanted to cherry pick this but there is no release branch (release-24.7) yet?

@NickLarsenNZ
Copy link
Member

Oh, good point!
Somehow I assumed it was done in the release scripts.

I guess we just need to add these things to the task list so we don't forget them.

@adwk67
Copy link
Member

adwk67 commented Jul 29, 2024

The release scripts don't touch the demos (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maltesander @NickLarsenNZ @adwk67