Skip to content

use specific ENV ENABLE_TRANSACTIONS_EXTENSIONS for transactions #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

use specific ENV ENABLE_TRANSACTIONS_EXTENSIONS for transactions #239

merged 2 commits into from
May 13, 2025

Conversation

vincentsarago
Copy link
Member

No description provided.

@vincentsarago vincentsarago requested a review from hrodmn May 13, 2025 11:44
hrodmn
hrodmn requested changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but you need to fix the env var name in docker-compose.yml to be ENABLE_TRANSACTIONS_EXTENSIONS.

Just a thought: should we handle the extensions env var and other logic using the pydantic settings rather than reading it in app.py?

@vincentsarago @hrodmn
Update docker-compose.yml
0d64261 
Co-authored-by: Henry Rodman <henry.rodman@gmail.com>
@vincentsarago
Copy link
Member Author

Just a thought: should we handle the extensions env var and other logic using the pydantic settings rather than reading it in app.py?

I though about it but didn't want to change to many things.

@vincentsarago vincentsarago merged commit 3749c12 into feat/disable-transaction-extensions May 13, 2025
@vincentsarago vincentsarago deleted the feat/disable-transaction-extensions-vs-edits branch May 13, 2025 12:05
vincentsarago added a commit that referenced this pull request May 13, 2025
@hrodmn @vincentsarago
disable transaction and bulk_transactions extensions by default (#236)
db9d81c 
* disable transaction and bulk_transactions extensions by default

resolves #231

* enable all extensions in cicd

* apply suggestions from review

Co-authored-by: Vincent Sarago <vincent@developmentseed.org>

* refactor fixtures

* remove unused

* use specific ENV ENABLE_TRANSACTIONS_EXTENSIONS for transactions (#239)

* use specific ENV ENABLE_TRANSACTIONS_EXTENSIONS for transactions

* Update docker-compose.yml

Co-authored-by: Henry Rodman <henry.rodman@gmail.com>

---------

Co-authored-by: Henry Rodman <henry.rodman@gmail.com>

* update changelog

---------

Co-authored-by: Vincent Sarago <vincent@developmentseed.org>
Co-authored-by: vincentsarago <vincent.sarago@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrodmn hrodmn hrodmn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentsarago @hrodmn