Skip to content

add pagination with search_after, other refactoring #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

add pagination with search_after, other refactoring #85

merged 2 commits into from
Mar 25, 2022

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented Mar 24, 2022 •
edited
Loading

Related Issue(s):

Description:

  • add next link with token-based pagination using ES search_after
  • refactor to pass sort as a separate value rather than including in Search object

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the changelog

philvarner
philvarner commented Mar 24, 2022
View reviewed changes
stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/database_logic.py
self,
search: Search,
limit: int,
token: Optional[str],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we need the token, and pass sort as a separate value instead of part of search

@philvarner philvarner marked this pull request as ready for review March 24, 2022 23:17
jonhealy1
jonhealy1 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@philvarner philvarner merged commit e2a943b into main Mar 25, 2022
@philvarner philvarner deleted the pv/pagination-with-search-after branch March 25, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philvarner @gadomski @jonhealy1