create indexes at startup rather than when ingesting, add collection index schema #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
commented
Mar 16, 2022
| def all_collections(self, **kwargs) -> Collections: | ||
| """Read all collections from the database.""" | ||
| base_url = str(kwargs["request"].base_url) | ||
| try: | ||
| collections = self.client.search( | ||
| index="stac_collections", doc_type="_doc", query={"match_all": {}} |
There was a problem hiding this comment.
doc_type is deprecated, and is assumed to be _doc
philvarner
commented
Mar 16, 2022
| def item_collection( | ||
| self, collection_id: str, limit: int = 10, **kwargs | ||
| self, collection_id: str, limit: int = 10, token: str = None, **kwargs |
There was a problem hiding this comment.
updated this signature wrt the ABC
philvarner
commented
Mar 16, 2022
| def post_search( | ||
| self, search_request: BaseSearchPostRequest, **kwargs | ||
| ) -> ItemCollection: | ||
| def post_search(self, search_request: Search, **kwargs) -> ItemCollection: |
There was a problem hiding this comment.
updated wrt the ABC
philvarner
commented
Mar 16, 2022
| session: Session = attr.ib(default=attr.Factory(Session.create_from_env)) | ||
| client = ElasticsearchSettings().create_client | ||
|
|
||
| ES_MAPPINGS_DYNAMIC_TEMPLATES = [ |
There was a problem hiding this comment.
copied from transactions.py.
philvarner
commented
Mar 16, 2022
| }, | ||
| } | ||
|
|
||
| ES_COLLECTIONS_MAPPINGS = { |
There was a problem hiding this comment.
added a mapping for collections -- same one used in stac-server
gadomski
reviewed
Mar 16, 2022
gadomski
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
PR Checklist:
pre-commit run --all-files)make test)make docs)