Skip to content

add support for Elasticsearch 8, default to running that for local tests, and test both 7 and 8 in CI #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 15, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

Description:

  • pin elasticsearch and elasticsearch-dsl libraries
  • add header for ES 8 that provides backwards compat with 7.
  • update CI tests to run against Elasticsearch 7 and 8

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the changelog

@@ -41,8 +41,4 @@ services:
http.port: 9200
ES_JAVA_OPTS: -Xms512m -Xmx512m
ports:
- 9200:9200

networks:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't do anything. name is not a property of default.

@philvarner philvarner changed the title Pv/update to elasticsearch 8 add support for Elasticsearch 8, default to running that for local tests, and test both 7 and 8 in CI Mar 15, 2022
@philvarner
Copy link
Collaborator Author

For some reason, the tests can't connect to ES 8 when running in CI. 🤷🏻 Worked fine locally.

@jonhealy1
Copy link
Collaborator

So weird

@philvarner
Copy link
Collaborator Author

Ah, so apparently it didn't work fine locally -- I think I still had a 7.x instance running.

The underlying issue is that security is enabled by default for 8.x, so that means (1) the elastic user has a password that gets generated at first startup and (2) TLS is required and has a self-signed cert. I've only found instructions on how to run this manually (e.g., "run the image and copy the password to your secure notes") and now how to do it in an automated way.

I think I'm going to merge these changes and only run against 7.x, and then at some point later we can get it running with 8.

@jonhealy1
Copy link
Collaborator

I guess make an issue

@philvarner philvarner merged commit d3acbae into main Mar 15, 2022
@philvarner philvarner deleted the pv/update-to-elasticsearch-8 branch March 15, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants