-
Notifications
You must be signed in to change notification settings - Fork 25
add support for Elasticsearch 8, default to running that for local tests, and test both 7 and 8 in CI #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Revert "revert mappings back to original ones" This reverts commit 317a99c.
@@ -41,8 +41,4 @@ services: | |||
http.port: 9200 | |||
ES_JAVA_OPTS: -Xms512m -Xmx512m | |||
ports: | |||
- 9200:9200 | |||
|
|||
networks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't do anything. name
is not a property of default.
This reverts commit f86ba35.
For some reason, the tests can't connect to ES 8 when running in CI. 🤷🏻 Worked fine locally. |
So weird |
Ah, so apparently it didn't work fine locally -- I think I still had a 7.x instance running. The underlying issue is that security is enabled by default for 8.x, so that means (1) the elastic user has a password that gets generated at first startup and (2) TLS is required and has a self-signed cert. I've only found instructions on how to run this manually (e.g., "run the image and copy the password to your secure notes") and now how to do it in an automated way. I think I'm going to merge these changes and only run against 7.x, and then at some point later we can get it running with 8. |
I guess make an issue |
Related Issue(s):
Description:
PR Checklist:
pre-commit run --all-files
)make test
)make docs
)