Skip to content

Make orjson usage more consistent #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025
Merged

Conversation

Zaczero
Copy link
Contributor

@Zaczero Zaczero commented Jun 10, 2025

Description:

It's a required dependency of core. May as well use it instead of the stdlib json where suitable.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Changelog entry only thing

@Zaczero
Copy link
Contributor Author

Zaczero commented Jun 12, 2025

I didn't do that because I thought it's too small of a change. I'll just always update the changelog from now on.

@Zaczero Zaczero requested a review from jonhealy1 June 12, 2025 13:16
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zaczero

@jonhealy1 jonhealy1 merged commit c779c9d into stac-utils:main Jun 12, 2025
15 checks passed
@Zaczero Zaczero deleted the more-orjson branch June 12, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants