replace use of RFC339 constant with equivalent code #40
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
commented
Mar 2, 2022
| @@ -104,7 +103,7 @@ def create_collection(self, model: stac_types.Collection, **kwargs): | |||
| def update_item(self, model: stac_types.Item, **kwargs): | |||
| """Update item.""" | |||
| base_url = str(kwargs["request"].base_url) | |||
| now = datetime.utcnow().strftime(DATETIME_RFC339) | |||
There was a problem hiding this comment.
I'm removing all the uses of DATETIME_RFC339 is stac-fastapi right now, and we can remove all the uses of it in this repo after that's done.
jonhealy1
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
replace use of RFC339 constant with equivalent code. That constant is both misnamed and no longer used in stac_pydantic, and may be removed in the future
PR Checklist:
pre-commit run --all-files)make test)make docs)