-
Notifications
You must be signed in to change notification settings - Fork 25
Add es_os_refresh env var to refresh index, ensure refresh passed via kwargs #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysrevans3
previously approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just one optional change 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
DATABASE_REFRESH
environment variable to control whether database operations refresh the index immediately after changes. If set totrue
, changes will be immediately searchable. If set tofalse
, changes may not be immediately visible but can improve performance for bulk operations. If set towait_for
, changes will wait for the next refresh cycle to become visible.TransactionsClient
to use the_resolve_refresh
helper method for consistent and reusable handling of therefresh
parameter.refresh
parameter fromkwargs
to the database logic, ensuring consistent behavior across all CRUD operations.PR Checklist:
pre-commit run --all-files
)make test
)