Allow landing page id to be configurable #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rhysrevans3. How do you feel about finishing this pr? It looks useful. |
|
We would just have to add an entry to the env variable section in the Readme and then something in the changelog as well maybe. We could also set the landing page id env in our docker containers if we wanted. |
…-elasticsearch into landing_page_id
…ch into landing_page_id
|
@jonhealy1 sorry I was away at a conference this should be ready for review now |
jonhealy1
requested changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow landing page id to be configured through env variable.
PR Checklist:
pre-commit run --all-files)make test)