Skip to content

iterate over the Item values rather than the Items string keys #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

  • n/a

Description:

This is also a bug in SQLAlchemy backend, an issue has been filed.

The problem is that the Items iter implementation iterates over the keys of the items (dict[string,Item]) rather than the values, so it gets a string (which is the id) instead of the Item itself. This iterates over the Items instead.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG, if applicable

@philvarner philvarner requested a review from jonhealy1 February 24, 2022 18:21
@jonhealy1
Copy link
Collaborator

jonhealy1 commented Feb 25, 2022

@philvarner Should we just implement the /items endpoint being able to process a feature collection? We could then add the code to stac-fastapi too potentially? Ultimately we would process a list of 'features' or items.

@philvarner
Copy link
Collaborator Author

I think we want to wait for it to be done in core stac-fastapi, and then update our impl as appropriate to however the api changes there.

Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

@philvarner philvarner merged commit 4eaedc5 into main Feb 25, 2022
@philvarner philvarner deleted the pv/fix-bulk-ingest branch February 25, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants