Skip to content

[FIX-132] - Closing ES client connections in ES index management functions #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2023
Merged

[FIX-132] - Closing ES client connections in ES index management functions #133

merged 1 commit into from
Jan 26, 2023

Conversation

ahuarte47
Copy link
Contributor

@ahuarte47 ahuarte47 commented Jan 26, 2023 •
edited
Loading

Related Issue(s):

Description:
This PR fixes the closing of ES client connections in ES index managment functions.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@ahuarte47 ahuarte47 force-pushed the main_fix-unclosed-connections branch from 39e3e1d to 672a85a Compare January 26, 2023 11:22
@ahuarte47 ahuarte47 changed the title Closing client connections [FIX-132] - Closing ES client connections in ES index management functions Jan 26, 2023
@ahuarte47
Copy link
Contributor Author

That 3 failed tests are working in local:

  • tests/resources/test_item.py::test_field_extension_post - IndexError: list index out of range
  • tests/resources/test_item.py::test_field_extension_exclude_and_include - IndexError: list index out of range
  • tests/resources/test_item.py::test_field_extension_exclude_default_includes - IndexError: list index out of range

jonhealy1
jonhealy1 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thank you @ahuarte47

@jonhealy1 jonhealy1 requested a review from philvarner January 26, 2023 12:37
@jonhealy1
Copy link
Collaborator

That 3 failed tests are working in local:

  • tests/resources/test_item.py::test_field_extension_post - IndexError: list index out of range
  • tests/resources/test_item.py::test_field_extension_exclude_and_include - IndexError: list index out of range
  • tests/resources/test_item.py::test_field_extension_exclude_default_includes - IndexError: list index out of range

I created an issue for this. #134

@jonhealy1 jonhealy1 merged commit 0085835 into stac-utils:main Jan 26, 2023
@ahuarte47 ahuarte47 deleted the main_fix-unclosed-connections branch January 26, 2023 14:39
@ahuarte47
Copy link
Contributor Author

Thanks @jonhealy1 @philvarner for your help!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philvarner philvarner philvarner approved these changes

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahuarte47 @jonhealy1 @philvarner