only one Item with a given id is allowed across all collections, rather than per collection

[philvarner]

The Item id is used as the ES document id, but this is not guaranteed to be unique globally. The document id must be unique per collection + item.

[jonhealy1]

@philvarner I think this is an issue with my limited knowledge of es. I have a collections index and an items index. I wanted to have an index for each collection of items instead of one big items index but I was confused about how to implement cross-collection queries. Someone said I could use aliases I think but I haven't looked into them yet.

[jonhealy1]

If we could fix this we could fix this issue too #34
I think

[jonhealy1]

You already created this issue which says what I just did basically #44

[philvarner]

it's a straightforward fix -- you do a "delete by query" operation matching on id and collection, instead of a delete by _id.

from stac-server:

 return await client.delete_by_query({
    index: collectionId,
    body: buildIdQuery(itemId),
    waitForCompletion: true
  })

where

function buildIdQuery(id) {
  return {
    query: {
      bool: {
        filter: {
          term: {
            id: id
          }
        }
      }
    }
  }
}

[jonhealy1]

Can we have two items with the same id right now?

[jonhealy1]

That's a different issue - I get it now

[philvarner]

I looked at this more, and I forgot the delete function takes a document id. I've done this in the past with delete_by_query which requires a filter.

Closing since this isn't actually an issue.