Production code is not being tested

[Zaczero]

Describe the bug

I've just noticed that you create a different StacApi app just for tests -- stac_fastapi/tests/conftest.py. This is surprising as the production code is not actually tested: because of that, during manual(deployment) testing of enum queryables they work fine, but because of different test configuration they don't. This is dangerous as the production code is left untested and it's a matter of luck that tests use the same code as production. I'll try to update the tests to resolve the issue, but I encourage you to discard this method of testing in favor of a single app instance for both production and tests.

[jonhealy1]

I don't think production code is untested but this is a good suggestion and is something that should definitely get done. Duplicating the the stac api app for tests does create more work and potential headaches.

[Zaczero]

I don't think production code is untested but this is a good suggestion and is something that should definitely get done. Duplicating the the stac api app for tests does create more work and potential headaches.

Okay I agree - the code isn't untested, it's just tested by accident. Breaking the application won't break tests, and breaking tests won't break the application, or it may... who knows 🤔. For production software, I don't think this approach is right (or in this case even necessary). Tests should verify actual application behavior.

PS. Don't take this the wrong way. This STAC implementation is great, and I simply want to point out issues to hopefully make everyone's experience better. Resolving this issue will not only improve the quality of the tests but also make it easier to contribute (instead of changing code in 2 or more places, it will be just 1). I have the benefit of a fresh pair of eyes looking at this code, and some things stand out to me better.