Skip to content

Adds missing translation for french language #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

orobardet
Copy link
Contributor

Some strings were missing in the french translation, this PR adds them.

@orobardet
Copy link
Contributor Author

orobardet commented Jul 20, 2021

The npm run build removed the file material/overrides/assets/javascripts/iconsearch_index.json and added a \n at the end of material/.icons/material/LICENSE.
Since it does not seems to have any relation to the new translations, I did not commit these changes.

But I can if needed.

@squidfunk
Copy link
Owner

Thanks!

The npm run build removed the file material/overrides/assets/javascripts/iconsearch_index.json and added a \n at the end of material/.icons/material/LICENSE.
Since it does not seems to have any relation to the new translations, I did not commit these changes.

Those changes don't belong here, that's correct. The icon index is only built when the twemoji database is found in the venv folder, which obviously isn't there on your installation:

const emojis$ = defer(() => resolve("venv/**/twemoji_db.py"))
.pipe(
switchMap(file => read(file)),
map(data => {
const [, payload] = data.match(/^emoji = ({.*})$.alias/ms)!
return Object.entries<TwemojiIcon>(JSON.parse(payload))
.reduce((index, [name, { unicode }]) => index.set(
name.replace(/(^:|:$)/g, ""),
`${unicode}.svg`
), new Map<string, string>())
})
)

It's specific to Material for MkDocs' own site, and is not necessary for the distribution. TL;DR: nevermind.

@squidfunk squidfunk merged commit d2ccbf3 into squidfunk:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants