Override globs #862
Closed
Override globs #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you attach your sqlc.yaml or sqlc.json file? I'd like to see how this works in practice. |
|
Looks like I should update to version 2, but here you go. |
|
Ping on this @kyleconroy |
added 3 commits
April 12, 2021 10:18
This lets us say things like '*.*_ksuid' should be of type 'github.com/segmentio/ksuid.KSUID', instead of having to list every single column in every single table. We can even say '*.*.*_ksuid' for every column, in every table, in every schema. Now, ideally we would do a type replace on 'binary(20)', however that gets turned into a char for at least the mysql code, which means that we never get to see 'binary(20)', and so can't do a replacement on it. This makes use of the github.com/gobwas/glob package for the globbing, and it pretty much Just Works the way you expect it to.
This doesn't get used, and so we can get rid of it instead of adapting it for globs.
Fairly straight forward, same changes as for the other code generators.
|
These changes have been rebased on the current head, specifically to add support for the python code generation. |
kyleconroy
requested changes
Jun 28, 2021
|
@zelch Going to close this one out, as it has conflicts and no tests. I'd be happy to support this change, but it needs to have test coverage. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I'm going to start with the use case.
Our MariaDB database has a lot of KSUIDs, enough that I would be better off writing a tool to automate building the override statements than doing it by hand.
It would be nice if we could just override on type, replace 'binary(20)' with 'github.com/segmentio/ksuid.KSUID' and call it a day.
Sadly, at least the mysql parser turns 'binary(20)' into 'char' well before the override code gets it. In fact, it does this well before any of the sqlc code gets it.
That leaves doing it by column name, but as mentioned above... There are quite a lot of them.
On the other hand, our naming convention is at least vaguely straight forward. The columns all end with _ksuid, so we can automatically detect them.
But why write rules to do this, and have a huge override table, when we can just add globbing support to sqlc?
And so I did that instead. :)
This passes all of the tests, and is reasonably straight forward.