sql/catalog: Add support for variadic functions #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovadbar
reviewed
Nov 19, 2020
| @@ -251,6 +251,7 @@ type Argument struct { | |||
| Name string | |||
| Type *ast.TypeName | |||
| HasDefault bool | |||
| Variadic bool | |||
There was a problem hiding this comment.
Why did you add this struct key when there is a mode for Variadic that you can use to check?
ovadbar
reviewed
Nov 19, 2020
| Name: "json_build_object", | ||
| Args: []*catalog.Argument{ | ||
| { | ||
| Type: &ast.TypeName{Name: "any"}, |
There was a problem hiding this comment.
Shouldn't you mark Variadic arguments as having defaults because there can b 0 of them otherwise the following would fail.
postgres=# select json_build_object();
json_build_object
-------------------
{}
(1 row)
ovadbar
reviewed
Nov 19, 2020
|
|
||
| const selectJSONBuildObject = `-- name: SelectJSONBuildObject :one | ||
| SELECT | ||
| json_build_object('foo'), |
There was a problem hiding this comment.
I would add the following edge case to the tests this will likely fail.
json_build_object(),
Also I would remove the following tests because they actually fail in postgresql with the error
"ERROR: argument list must have even number of elements"
json_build_object('foo'),
json_build_object('foo', 1, 2),
But catching those cases would be a little more difficult to catch without custom coding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761