Skip to content

mysql update docs with env vars, update test with json field, fill cl… #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2020
Merged

mysql update docs with env vars, update test with json field, fill cl… #742

merged 3 commits into from
Oct 26, 2020

Conversation

kristijorgji
Copy link
Contributor

@kristijorgji kristijorgji commented Oct 23, 2020

  • drop the test db after test finishes. I runned the tests several times and had many random named databases created, this fixes it
  • update docs to specify the mysql env vars used in order to make it easier for contributing
  • add one json field type in the example update models and test for that too

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ondeck example is shared across MySQL and PostgreSQL, so I'd like to keep it the same. Please remove the added JSON column. A MySQL JSON example already exists in the form of an end-to-end test.

Really appreciate the README updates!

Kristi Jorgji and others added 2 commits October 23, 2020 20:36
…eanup function wip see why error happens unkown json type with mysql engine
@kristijorgji
Copy link
Contributor Author

The ondeck example is shared across MySQL and PostgreSQL, so I'd like to keep it the same. Please remove the added JSON column. A MySQL JSON example already exists in the form of an end-to-end test.

Really appreciate the README updates!

Done, reverted that change please re-review

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've rebased your changes onto master and will merge once the build passes.

@kyleconroy kyleconroy merged commit 7141539 into sqlc-dev:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants