dolphin: Add ENUM() support #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this now, but will revisit the naming scheme before v1.6.0 is released. |
alecbz
reviewed
Sep 21, 2020
| } | ||
| if col.Vals != nil { | ||
| typeName := ast.TypeName{ | ||
| Name: col.Colname, |
There was a problem hiding this comment.
@kyleconroy I'm not 100% sure when this if triggers (for columns that use an implicit enum for the type, instead of a named one?) but this breaks with "type already exists" if it triggers twice for the same column name.
Thoughts on how to address? Prepending the table's name might be an easy-ish fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still deciding on how to pick the type name for MySQL enums. See the discussion in #502