Support SELECT * in MySQL #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinburke1
reviewed
May 29, 2020
| case config.EnginePostgreSQL: | ||
| return r.postgresType(col, settings) | ||
| case config.EngineXLemon: | ||
| return r.postgresType(col, settings) |
There was a problem hiding this comment.
Why wouldn't you have this in the same case statement as the line above?
There was a problem hiding this comment.
Should have left a comment; calling postgresType for SQLite is a temporary solution. SQLite offers a very small number of built in types and should not use the same mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the compiler package and generic AST