MySQL experimental parser #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleconroy
force-pushed
the
mysql-experiment
branch
from
b77c8df to
6d08b32
Compare
kyleconroy
force-pushed
the
mysql-experiment
branch
from
6d08b32 to
8f72da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original plan was to use the pingcap MySQL parser when
env.ExperimentalParserwas true, and the vitess parser when it was false. Sadly, that won't really work as the two parsers aren't the same.Instead, we'll only use the pingcap parser if the engine is set to
_dolphin. We'll eventually switch over, once the pingcap-based parser is further along.