Skip to content

docs: Avoid test failure #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2024
Merged

docs: Avoid test failure #3235

merged 1 commit into from
Mar 3, 2024

Conversation

zawataki
Copy link
Contributor

@zawataki zawataki commented Mar 1, 2024

Summary

Add sqlc-gen-json installation step to avoid the following error when tests running.

--- FAIL: TestReplay (0.13s)
    --- FAIL: TestReplay/base/process_plugin_sqlc_gen_json (0.01s)
        endtoend_test.go:231: sqlc generate failed: # package jsonb
            error generating code: process: sqlc-gen-json not found
FAIL
FAIL	github.com/sqlc-dev/sqlc/internal/endtoend	2.156s

How to reproduce the error

  1. Clone the repo (I tried the latest commit: 8d7ec15)
  2. Run tests by go test ./... command
  3. The error occurs

@zawataki
Avoid test failure
1bcae85 
Add sqlc-gen-json installation step to 
avoid "error generating code: process: sqlc-gen-json not found"
when tests running.
@zawataki zawataki changed the title Avoid test failure docs: Avoid test failure Mar 1, 2024
@kyleconroy kyleconroy merged commit b8160b5 into sqlc-dev:main Mar 3, 2024
@zawataki zawataki deleted the avoid-test-failure branch March 3, 2024 08:22
lisitsky pushed a commit to lisitsky/sqlc that referenced this pull request Jun 21, 2024
@zawataki @lisitsky
docs(development): Avoid test failure (sqlc-dev#3235)
ae63775 
Add sqlc-gen-json installation step to 
avoid "error generating code: process: sqlc-gen-json not found"
when tests running.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zawataki @kyleconroy