feat(plugin): Calculate SHA256 if it does not exist #2935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When developing or using a plugin locally, having to update the configuration file every time to pull in a SHA256 can be very annoying. When fetching a plugin for the first time via HTTP, you may not know the SHA256 of the file you're fetching.
I've changed the plugin fetching behavior to calculate the SHA256 if it's not present. This results in extra network requests or filesystem reads, so it's still advised to set the SHA256, especially if it's not changing.
Before release, we'll add some logging to make it clear the extra requests are happening.