Skip to content

Fix: Perform nil check for join constraint #2730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jamietanna
Copy link

Closes #2729.

@andrewmbenton
Copy link
Collaborator

I'm not sure the effect of treating a nil Join_constraint as a no-op is "correct". I'm not well-versed in our sqlite parser and conversion code, but maybe @orisano or @kyleconroy can weigh in.

In any case you're right that we should add a new endtoend test or a new query to an existing test for this.

@kyleconroy
Copy link
Collaborator

He's already on it! Fixed here #2732

@kyleconroy kyleconroy closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlc panics on v1.21.0 in sqlite.getTables
3 participants