fix: clarify error message for PostgreSQL Engine support #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When trying to build the project under a fresh Ubuntu WSL install, tests would fail with the error "the PostgreSQL engine does not support Windows" - however, the actual reason was that
gccwas not installed, therefore CGO was not available. This occurred because postgresql/parse_disabled.go is included when building on windows OR when CGO is not available - however it's possible (as in my case) to be running in a linux environment and still have CGO unavailable.Solution
This PR updates the error message to clarify that both Windows and any environment without CGO is not supported.