Skip to content

parser: Generate correct types for SELECT NOT EXISTS #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2023
Merged

parser: Generate correct types for SELECT NOT EXISTS #1972

merged 1 commit into from
Feb 23, 2023

Conversation

haines
Copy link
Contributor

@haines haines commented Nov 30, 2022 •
edited
Loading

Fixes #1140

Currently, SELECT NOT EXISTS queries produce any-typed results. This PR makes them produce bool-typed results, and defaults the column name to not_exists to mirror the behaviour of SELECT EXISTS queries.

@mpyw mpyw mentioned this pull request Jan 12, 2023
Closed
@haines haines force-pushed the select-not-exists branch from 565ec8d to ae37ca7 Compare February 2, 2023 12:29
@haines
parser: Generate correct types for SELECT NOT EXISTS
02db523 
Signed-off-by: Andrew Haines <andrew@haines.org.nz>
@kyleconroy kyleconroy merged commit ed5ffbc into sqlc-dev:main Feb 23, 2023
@haines haines deleted the select-not-exists branch February 23, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleconroy kyleconroy kyleconroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'SELECT NOT EXISTS' queries should return bool, but doesn't
2 participants
@haines @kyleconroy