Skip to content

internal/dinosql: Add COMMENT ON support #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

internal/dinosql: Add COMMENT ON support #191

merged 1 commit into from
Dec 17, 2019

Conversation

kyleconroy
Copy link
Collaborator

Comments are supported for SCHEMA, TABLE, COLUMN, and TYPE.

Fixes #187

Comments are supported for SCHEMA, TABLE, COLUMN, and TYPE.
@kyleconroy kyleconroy merged commit 40c71de into master Dec 17, 2019
@kyleconroy kyleconroy deleted the comment-on branch December 17, 2019 20:17
@maxhawkins
Copy link
Contributor

Related to #193:

This breaks if one of your comments is on a view.

CREATE TABLE users (name TEXT);

CREATE VIEW harrys AS
  SELECT name
  FROM users
  WHERE name ILIKE '%harry%';

COMMENT ON harrys.name IS 'Harry's name';

relation "harrys" does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add schema comments to models.go
2 participants