Skip to content

Inflection Singular table names exclusion configuration #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2022

Conversation

danicc097
Copy link
Contributor

Fixes #1526

Not a fan of exclude_table_names being so ambiguous, but emit_exact_table_names is already taken. Any ideas for that or is it good enough?

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I think you're right that exclude_table_names isn't a good name. I'll think about some alternatives that we can use.

@kyleconroy
Copy link
Collaborator

Let's go with inflection_exclude_table_names. It's still not great, but I want to unblock us.

@kyleconroy
Copy link
Collaborator

@danicc097 You'll need to rebase as the configuration / proto files have changed.

@kyleconroy kyleconroy merged commit 73cbcf3 into sqlc-dev:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model generation inflection naming
2 participants