Skip to content

Add sqlc.slice() new function type (#695) #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add sqlc.slice() new function type (#695) #1312

wants to merge 1 commit into from

Conversation

cameronpm
Copy link
Contributor

This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

The MySQL FLOAT datatype mapping has been added too.

@cameronpm
Add sqlc.slice() new function type (sqlc-dev#695)
a59d951 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

The MySQL FLOAT datatype mapping has been added too.
@cameronpm
Copy link
Contributor Author

Conflicts with future slated changes (ast based codegen - #1333), withdrawing

@cameronpm cameronpm closed this Dec 8, 2021
Jille added a commit to Jille/sqlc that referenced this pull request Aug 23, 2022
@Jille @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (sqlc-dev#695)
a8024fd 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
@Jille Jille mentioned this pull request Aug 23, 2022
Merged
Jille added a commit to Jille/sqlc that referenced this pull request Aug 23, 2022
@Jille @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (sqlc-dev#695)
5515aa5 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
Jille added a commit to Jille/sqlc that referenced this pull request Aug 23, 2022
@Jille @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (sqlc-dev#695)
8ca1ff1 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
Jille added a commit to Jille/sqlc that referenced this pull request Jan 2, 2023
@Jille @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (sqlc-dev#695)
ab9b58e 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
Jille added a commit to Jille/sqlc that referenced this pull request Jan 2, 2023
@Jille @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (sqlc-dev#695)
47ae53f 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
Jille added a commit to Jille/sqlc that referenced this pull request Apr 3, 2023
@Jille @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (sqlc-dev#695)
08fd504 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
kyleconroy pushed a commit that referenced this pull request Apr 7, 2023
@Jille @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (#695) (#1816)
a8477b8 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on #1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
eliteprodev pushed a commit to eliteprodev/safesql_generator that referenced this pull request May 17, 2023
@cameronpm
Add sqlc.slice() to support IN clauses in MySQL (#695) (#1816)
bc96f40 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev/sqlc#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
eliteprodev added a commit to eliteprodev/safesql_generator that referenced this pull request Jun 26, 2023
@eliteprodev @cameronpm
Add sqlc.slice() to support IN clauses in MySQL (#695) (#1816)
7ca2bde 
This feature (currently MySQL-specific) allows passing in a slice to an
IN clause. Adding the new function sqlc.slice() as opposed to overloading
the parsing of "IN (?)" was chosen to guarantee backwards compatibility.

   SELECT * FROM tab WHERE col IN (sqlc.slice("go_param_name"))

This commit is based on sqlc-dev/sqlc#1312 by
Paul Cameron. I just rebased and did some cleanup.

Co-authored-by: Paul Cameron <cameronpm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cameronpm