fix(compiler): Set RV for TargetList items on updates

[andreasgangso]

Hi, thank you for this library!
I stumbled upon a bug with updates not working on update queries with multiple tables. It gave an error column does not exist which was because ref.rv was nil.
This PR fixes this by looping through the TargetList and setting the ref.rv from the Relation, similarly to what inserts already do. Here's the relevant AST:

   Relation: (*ast.RangeVar)(0xc000ac2ab0)({
    Catalogname: (*string)(<nil>),
    Schemaname: (*string)(<nil>),
    Relname: (*string)(0xc000aa3b40)((len=5) "media"),
    Inh: (bool) true,
    Relpersistence: (uint8) 112,
    Alias: (*ast.Alias)(0xc000aa3b60)({
     Aliasname: (*string)(0xc000aa3b50)((len=2) "m1"),
     Colnames: (*ast.List)(0xc000aa75f0)({
      Items: ([]ast.Node) <nil>
     })
    }),
    Location: (int) 1469
   }),
   TargetList: (*ast.List)(0xc000aa7608)({
    Items: ([]ast.Node) (len=1 cap=1) {
     (*ast.ResTarget)(0xc000ac2ae0)({
      Name: (*string)(0xc000aa3b70)((len=9) "agerating"),
      Indirection: (*ast.List)(0xc000aa7620)({
       Items: ([]ast.Node) <nil>
      }),
      Val: (*ast.ParamRef)(0xc000527f98)({
       Number: (int) 5,
       Location: (int) 1696,
       Dollar: (bool) true
      }),
      Location: (int) 1684
     })
    }
   }),

[andreasgangso]

Sure, but it will take a few days before I have time

[kyleconroy]

Can you please add at least one test case? There are many examples in the internal/endtoend/testdata directory.

[andreasgangso]

Sorry, yes. I'll do it tomorrow. Andreas

…

On Mon, Nov 1, 2021, 16:06 Kyle Conroy ***@***.***> wrote: ***@***.**** requested changes on this pull request. Can you please add at least one test case? There are many examples in the internal/endtoend/testdata directory. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1252 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFRQVJR456P3DD7KFDDGU3UJ2UIJANCNFSM5G4W26XA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[kyleconroy]

@andreasgan Sorry for the second message! I realized that I hadn't posted the comment as a review. No rush, seriously.

[andreasgangso]

@andreasgan Sorry for the second message! I realized that I hadn't posted the comment as a review. No rush, seriously.

No worries. Tests added now.