Add support for mysql CTEs. #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 14, 2021 17:49
This is needed as CTE support is fairly new for the parser.
pcast.RenameTableStmt was modified in the current parser to only have the list of renames, instead of both a single set of data for renames and the list. As such we need to turn that into an ast.List of ast.RenameTableStmt.
The mysql code now uses an ast.List for all rename statements, however Catalog.Update ignores ast.List items instead of walking through them, this results in the renames getting lost. This change causes us to go through each list, assuming that they may contain statements.
These will be used by the different types that have With objects.
This should give us full support for CTEs (recursive and not) for mysql. All types that parser has With entries for, and which we currently support, are handled here.
This just copies the stdlib test cases to mysql, sets the engine, and switches to mysql style parameters. Otherwise, no changes to the tests or the expected test output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the current version of github.com/pingcap/parser, fixes rename support (altered in the newer version of parser), and then adds support for mysql CTEs that exists in the newer version of parser.
This also creates mysql versions of all of the existing CTE test cases, the only things that had to be changed for those test cases from the stdlib test cases was setting the engine, and changing the parameter style from $1 to ?.