Add support for ARM architecture

[aitva]

I built sqlc on an ARM64 laptop and I got this error:

# github.com/lfittl/pg_query_go/parser
In file included from go/src/github.com/lfittl/pg_query_go/parser/include/utils/dsa.h:17:0,
                 from go/src/github.com/lfittl/pg_query_go/parser/include/nodes/tidbitmap.h:26,
                 from go/src/github.com/lfittl/pg_query_go/parser/include/access/genam.h:19,
                 from go/src/github.com/lfittl/pg_query_go/parser/include/nodes/execnodes.h:17,
                 from go/src/github.com/lfittl/pg_query_go/parser/include/commands/trigger.h:17,
                 from go/src/github.com/lfittl/pg_query_go/parser/include/plpgsql.h:21,
                 from pg_query_json_plpgsql.h:5,
                 from pg_query_json_plpgsql.c:2:
go/src/github.com/lfittl/pg_query_go/parser/include/port/atomics.h:68:35: fatal error: port/atomics/arch-arm.h: No such file or directory
 #include "port/atomics/arch-arm.h"
                                   ^
compilation terminated.

There is an open issue lfittl/pg_query_go#27 for ARM support in pg_query_go. Using the fix mentioned and go mod edit I was able to build a working version of sqlc.

If you are interested, I can fork pg_query_go and fix lfittl/pg_query_go#24, lfittl/pg_query_go#26 and lfittl/pg_query_go#27.

[kyleconroy]

If you are interested

Very interested!

I can fork pg_query_go and

I'm actually going to need to fork pg_query_go to add support for PostgreSQL 11 and 12. I created my work fork here (https://github.com/kyleconroy/pg_query_go/) and added you as a collaborator. You can do the work there, or just do the work on your own fork and I'll pull it into mine. Up to you.

[aitva]

I tried to update https://github.com/kyleconroy/pg_query_go/ to PostgreSQL 12 during the weekend.

Here is a little debrief of what I found:

• https://github.com/lfittl/pg_query_go depends upon https://github.com/lfittl/libpg_query
• there is a Pull Request to support PostgreSQL 12
• the author of the Pull Request made a lot of change to the original repository:
  • in the original repository, a Ruby script copy the necessary C sources from Postgres to
    libpg_query
  • in the updated repository, all the work is done by gcc and a C static library is generated

I was able to generate the static library and I tried to build pg_query_go against it but it does not work. I discovered that the library built by the updated libpg_query is a thin archive. Thus, not portable. I spent a lot of time trying to generate a portable C library, but I was not able to finish during the weekend.

So far, the C static library is huge (around 100Mo), and is not portable. We will need to build it for every platform we want to support and keep them in libpg_query and pg_query_go.

I am not sure that we can use the updated libpg_query as is. Keeping 1Go of C libraries in the repository does not seem like the way forward. I prefer the approche taken by @lfittl to include all the necessary C code inside libpg_query, so we can embed it in pg_query_go and let cgo handle the build.

When I have some free time, I'd like to see if it is possible to get the list of files used by GCC or Clang during a build. So I can keep the work done to port libpg_query to Postgres 12, and keep @lfittl approche and copy all the needed source into the repository.

Sorry for the long post, don't hesitate if you have any questions or suggestions.

[kyleconroy]

Sorry for the long post, don't hesitate if you have any questions or suggestions.

Don't apologize, this is awesome! I've been heads down on type-checking internals, so it's super interesting to learn how pg_query_go works.

Right now, I think it's more important to update pg_query_go to Postgres 12. If we do that first, we can then solve a bunch of issues before starting the ARM port.

[aitva]

I sent a pull request #779 to update https://github.com/lfittl/pg_query_go to v1.0.1. The release adds ARM header files and the build is passing on my machine.

[kyleconroy]

@aitva I believe we're now using the new version of pg_query_go. What do I need to do next?

[aitva]

Thank you for the fix! I miss the pull request from dependabot. We can close the issue, go get and go build are working on arm machines. 🥳