Renaming enum values via migration doesn't update the generated code

[alibitek]

migration 0:

DROP TYPE IF EXISTS e_my_enum_type CASCADE;
CREATE TYPE e_my_enum_type AS ENUM (
    'green',
    'red',
    'black'
    );

generated code for migration 0:

type EMyEnumType string

const (
	EMyEnumTypeGreen EMyEnumType = "green"
	EMyEnumTypeRed   EMyEnumType = "red"
	EMyEnumTypeBlack EMyEnumType = "black"
)

Problem

migration 5:
ALTER TYPE e_my_enum_type RENAME VALUE 'black' TO 'yellow';

generated code after migration 5 is applied is the same as migration 0 for type EMyEnumType

Expected that it would be:

type EMyEnumType string

const (
	EMyEnumTypeGreen EMyEnumType = "green"
	EMyEnumTypeRed   EMyEnumType = "red"
	EMyEnumTypeBlack EMyEnumType = "yellow"
)

[mmcloughlin]

It appears that ALTER TYPE ... ADD VALUE ...; is also ignored. I did a quick test with a migration file containing:

CREATE TYPE task_status AS ENUM (
  'created',
  'in_progress'
);

ALTER TYPE task_status ADD VALUE 'complete';

The generated code only contains the initial two values.

[mmcloughlin]

Working on a PR.

[kyleconroy]

Just a heads up that I'm also working on a PR, we may not want to duplicate work.

[mmcloughlin]

Just a heads up that I'm also working on a PR, we may not want to duplicate work.

Oh cool! Well if you're okay to do it, fine by me :)

[mmcloughlin]

FWIW this was my work in progress, not that you need it haha.

diff --git a/internal/catalog/build.go b/internal/catalog/build.go
index 62359c1..bc629e2 100644
--- a/internal/catalog/build.go
+++ b/internal/catalog/build.go
@@ -99,6 +99,79 @@ func Update(c *pg.Catalog, stmt nodes.Node) error {
 
 	switch n := raw.Stmt.(type) {
 
+	case nodes.AlterEnumStmt:
+		// (pg_query.AlterEnumStmt) {
+		//  TypeName: (pg_query.List) {
+		//   Items: ([]pg_query.Node) (len=1 cap=1) {
+		//    (pg_query.String) {
+		//     Str: (string) (len=6) "status"
+		//    }
+		//   }
+		//  },
+		//  OldVal: (*string)(0xc000228e30)((len=6) "closed"),
+		//  NewVal: (*string)(0xc000228e40)((len=8) "not_open"),
+		//  NewValNeighbor: (*string)(<nil>),
+		//  NewValIsAfter: (bool) false,
+		//  SkipIfNewValExists: (bool) false
+		// }
+		// (pg_query.AlterEnumStmt) {
+		//  TypeName: (pg_query.List) {
+		//   Items: ([]pg_query.Node) (len=1 cap=1) {
+		//    (pg_query.String) {
+		//     Str: (string) (len=6) "status"
+		//    }
+		//   }
+		//  },
+		//  OldVal: (*string)(<nil>),
+		//  NewVal: (*string)(0xc0002b4890)((len=7) "unknown"),
+		//  NewValNeighbor: (*string)(<nil>),
+		//  NewValIsAfter: (bool) true,
+		//  SkipIfNewValExists: (bool) false
+		// }
+		// (pg_query.AlterEnumStmt) {
+		//  TypeName: (pg_query.List) {
+		//   Items: ([]pg_query.Node) (len=1 cap=1) {
+		//    (pg_query.String) {
+		//     Str: (string) (len=6) "status"
+		//    }
+		//   }
+		//  },
+		//  OldVal: (*string)(<nil>),
+		//  NewVal: (*string)(0xc0002b4980)((len=7) "unknown"),
+		//  NewValNeighbor: (*string)(<nil>),
+		//  NewValIsAfter: (bool) true,
+		//  SkipIfNewValExists: (bool) true
+		// }
+
+		fqn, err := ParseList(n.TypeName)
+		if err != nil {
+			return err
+		}
+		schema, exists := c.Schemas[fqn.Schema]
+		if !exists {
+			return wrap(pg.ErrorSchemaDoesNotExist(fqn.Schema), raw.StmtLocation)
+		}
+		typ, exists := schema.Types[fqn.Rel]
+		if !exists {
+			return wrap(pg.ErrorTypeDoesNotExist(fqn.Rel), raw.StmtLocation)
+		}
+		enum, ok := typ.(pg.Enum)
+		if !ok {
+			return wrap(pg.ErrorTypeIsNotEnum(fqn.Rel), raw.StmtLocation)
+		}
+
+		switch {
+		case n.OldVal != nil && n.NewVal != nil:
+			replaced := false
+			for i, val := range enum.Vals {
+				if val == n.OldVal {
+					enum.Vals[i] = *n.NewVal
+					replaced = true
+				}
+			}
+
+		}
+
 	case nodes.AlterObjectSchemaStmt:
 		switch n.ObjectType {
 
diff --git a/internal/catalog/build_test.go b/internal/catalog/build_test.go
index f2df039..a5e0e75 100644
--- a/internal/catalog/build_test.go
+++ b/internal/catalog/build_test.go
@@ -45,6 +45,43 @@ func TestUpdate(t *testing.T) {
 				},
 			},
 		},
+		{
+			`
+			CREATE TYPE status AS ENUM ('open', 'closed');
+			ALTER TYPE status RENAME VALUE 'closed' TO 'not_open';
+			`,
+			pg.Catalog{
+				Schemas: map[string]pg.Schema{
+					"public": {
+						Types: map[string]pg.Type{
+							"status": pg.Enum{
+								Name: "status",
+								Vals: []string{"open", "not_open"},
+							},
+						},
+					},
+				},
+			},
+		},
+		{
+			`
+			CREATE TYPE status AS ENUM ('open', 'closed');
+			ALTER TYPE status ADD VALUE 'unknown';
+			ALTER TYPE status ADD VALUE IF NOT EXISTS 'unknown';
+			`,
+			pg.Catalog{
+				Schemas: map[string]pg.Schema{
+					"public": {
+						Types: map[string]pg.Type{
+							"status": pg.Enum{
+								Name: "status",
+								Vals: []string{"open", "closed", "unknown"},
+							},
+						},
+					},
+				},
+			},
+		},
 		{
 			"CREATE TABLE venues ();",
 			pg.Catalog{
diff --git a/internal/pg/errors.go b/internal/pg/errors.go
index dc58c6b..42a311f 100644
--- a/internal/pg/errors.go
+++ b/internal/pg/errors.go
@@ -71,6 +71,13 @@ func ErrorTypeDoesNotExist(typ string) Error {
 	}
 }
 
+func ErrorTypeIsNotEnum(typ string) Error {
+	return Error{
+		Code:    "42809",
+		Message: fmt.Sprintf("%s is not an enum", typ),
+	}
+}
+
 // severity: ERROR
 // code: 42701
 // message: column "bar" of relation "foo" already exists

[kyleconroy]

Thanks! That's actually pretty helpful.