Wrong output of override

[juliusmh]

Version

1.24.0

What happened?

Override doesn't seem to work properly for foreign fields. I expected the profile_id column to translate to uuid.UUID.

Relevant log output

type CreateQueryParams struct {
    ID           uuid.UUID
    ProfileID    pgtype.UUID
}
// and
type Query struct {
    ID           uuid.UUID
    ProfileID    pgtype.UUID

Database schema

CREATE TABLE query
(
    id           uuid PRIMARY KEY,
    profile_id   uuid REFERENCES profile (id) ON DELETE CASCADE
)

SQL queries

-- name: CreateQuery :one
INSERT INTO query(id,profile_id) VALUES ($1, $2) RETURNING *;

Configuration

overrides:
  - db_type: "uuid"
    go_type:
      import: "github.com/google/uuid"
      type: "UUID"

Playground URL

No response

What operating system are you using?

macOS

What database engines are you using?

PostgreSQL

What type of code are you generating?

Go

[shkvoretz]

yeah, same issue here. This is somewhat critical. We are using decimal package so this is a showstopper.

[shkvoretz]

ok, I have figured out what's wrong with it in my case. I was overriding numeric like this

  - db_type: "pg_catalog.numeric"
    nullable: false                          
    go_type:
      import: "yapi/types"
      type: "Decimal"
  - db_type: "pg_catalog.numeric"
    nullable: true                          
    go_type:
      import: "yapi/types"
      type: "Decimal"        

this was generating model ok, but not the queries. I fixed it by duplicating the above for numeric type but without the schema

  - db_type: "numeric"
    nullable: false                          
    go_type:
      import: "yapi/types"
      type: "Decimal"
  - db_type: "numeric"
    nullable: true                          
    go_type:
      import: "yapi/types"
      type: "Decimal"   

The issue appears in gen.go file here

structs := buildStructs(req, options)
queries, err := buildQueries(req, options, structs)

buildStructs works off schema.Tables, while buildQueries off req.Queries.Params

These functions need to be aligned to use schema data from the same source.

I'll just stick with my workaround for now, as I don't have time to fix this - it appears some significant changes may be required here.

This misalignment is likely to cause other issues, I'm sure.

[trevatk]

@shkvoretz @juliusmh Found a quick fix for it. Issue seems to be in go_type.go

		if oride.DbType != "" && oride.DbType == columnType && oride.Nullable != notNull && oride.Unsigned == col.Unsigned {
			return oride.GoType.TypeName
		}

settings the go oride.Nullable == notNull seems to have fixed the issue for me.

[kyleconroy]

@juliusmh I know it might no seem like it, but the generated code for your example is correct. The profile_id column references the profile table, but the column itself is nullable, hence the uuid.NullUUID. You can either add a NOT NULL constraint to that column or change your override to target the specific column.

[juliusmh]

@kyleconroy the code you shared is correct, but not the bug that I was reporting earlier. The problem is that profile ID would be pgtype.UUID in the params. The code generated for you is different if you compare it to what I posted above. Did you use v1.23?

[alimoli]

Any news regarding this? I am getting the same problem.