Skip to content

Query annotations still have many side cases #1469

Closed
@raymond-design

Description

@raymond-design

Shouldn't every failure to generate sql code lead to a syntax warning? There still seems to be many ways to go around query annotation validations and get cases where nothing is generated and no error is logged.

Some side cases:

https://play.sqlc.dev/p/eda463647d63d4cf8567b5236c3a691c7b2b451f67a5b06dac33ce2936610848

Previously raised issues:

I'm aware that in earlier issues like #859, annotations like:
--name : DeleteAuthor :exec
have been fixed.

However, an annotation like:
--nam : DeleteAuthor :exec
could be typed, and no error is thrown.

I think we could just make the validation very strict and not have to deal with any annotation loopholes again. Any thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions