Skip to content

add additional hive config for xgboost codegen #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 28, 2019

Conversation

sperlingxx
Copy link
Contributor

fix #728

Copy link
Collaborator

@weiguoz weiguoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -246,6 +232,8 @@ func fillDatabaseInfo(r *filler, db *DB) (*filler, error) {
if err != nil {
return nil, err
}
r.Auth = cfg.Auth
r.Session = cfg.SessionCfg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice practice!

@weiguoz weiguoz self-requested a review August 28, 2019 06:33
weiguoz
weiguoz previously approved these changes Aug 28, 2019
@sperlingxx sperlingxx merged commit 95a6d90 into sql-machine-learning:develop Aug 28, 2019
@sperlingxx sperlingxx deleted the xgboost_dev branch August 28, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use XGBoost and TensorFlow at the same time.
3 participants